Simple Internationalization

[stonelasley]

I'll have to look into circleci but Saturday is calling. AppVeyor is stalled out asking for ionic/cli-plugin-ionic-angular so it probably needs to be updated beyond 3.4.0. @lathonez if you see this while it's broken It would be great if you could try rebuilding on circleci without cache.

[lathonez]

@stonelasley - looks good mate but it'll be a while until I have time to take a look.

[hfwittmann]

I am confused what I should do now, I suppose I'll wait in the wings until this one is in...

[stonelasley]

@hfwittmann sorry if I stepped on your toes with this PR.

[stonelasley]

Ok, could use a little help on this one. CircleCI I'm not going to pursue until we can try a build without cache, although we may see it fail on the e2e tests just like app veyor. I'm having a hell of a time reproducing these results locally so I apologize for the PR spam. The problem is the check is happening before the title has been translated. browser.waitForAngular() seems to work on my machine but obviously not on appveyor. I think the simplest solution is to introduce another delay but there has to be a more elegant solution?

[hfwittmann]

@stonelasley no problem

[stonelasley]

Killing PR again to troubleshoot e2e test

[lathonez]

@stonelasley

• Add --no-progress to the test-ci command in package.json for better logging
• Add an npm install step to .circle/config.yml, something like:

- run:
          name: install deps
          command: npm install

The dependencies are baked into the Dockerfile, I'll update it when I merge this in. The abvoe should get circle passing I think.

[stonelasley]

@lathonez excellent thank you!

[stonelasley]

@lathonez, I should be able to sort these out this week. Thanks for the comments.

[lathonez]

Will rebase this and get it merged this week

[lathonez]

280