lathonez / clicker

Ionic 2 + @angular/cli Seed Project : Angular2 + Typescript + Karma + Protractor + Travis
http://lathonez.com/2018/ionic-2-unit-testing/
MIT License
430 stars 137 forks source link

Undesirable Warning: Critical dependency: the request of a dependency is an expression #282

Closed martialp closed 6 years ago

martialp commented 6 years ago

I get this Undesirable warning 4 times when running npm test:

WARNING in ./node_modules/ionic-angular/es2015/util/ng-module-loader.js
25:11-36 Critical dependency: the request of a dependency is an expression
 @ ./node_modules/ionic-angular/es2015/util/ng-module-loader.js
 @ ./node_modules/ionic-angular/es2015/util/module-loader.js
 @ ./node_modules/ionic-angular/es2015/components/modal/modal-component.js
 @ ./node_modules/ionic-angular/es2015/index.js
 @ ./src/test.ts
lathonez commented 6 years ago

https://github.com/angular/angular/issues/11580

I don't want to add a webpack config file I need to maintain to remove this warning. You can do yourself if you want to: