Add mbed_nano to list of compatible architectures

lathoub / Arduino-BLE-MIDI

MIDI over Bluetooth Low Energy (BLE-MIDI) 1.0 for Arduino

MIT License

219 stars 33 forks source link

Add mbed_nano to list of compatible architectures #28

Closed per1234 closed 3 years ago

per1234 commented 3 years ago

In the 2.0.0 release of the Arduino Mbed OS Boards platform, the mbed architecture split into four architectures:

mbed_edge: Arduino Edge Control
mbed_nano: Nano 33 BLE and Nano RP2040 Connect
mbed_rp2040: Raspberry Pi Pico
mbed_portenta: Portenta H7

The mbed architecture should be retained for backwards support, but the new mbed_nano should also be added to avoid spurious incompatibility warnings and the library's examples being shown under the File > Examples > INCOMPATIBLE menu of the Arduino IDE when the Nano 33 BLE board is selected.

lathoub commented 3 years ago

Super, thank @per1234 - once IDE 2 is out, i will accept and merge this PR

per1234 commented 3 years ago

You're welcome.

once IDE 2 is out, i will accept and merge this PR

The reasons for this are not clear to me. The architectures change is related to the 2.0.0 release of the Arduino Mbed OS Boards platform: https://github.com/arduino/ArduinoCore-mbed/releases/tag/2.0.0 that happened a month ago. It affects all development software that uses the platform (Arduino IDE, Arduino IDE 2.x, Arduino CLI, Arduino Web Editor, 3rd party offerings). So I don't see a reason to make the merging contingent on the release of the Arduino IDE 2.0.0. But of course the decision of if/when to merge is yours to make.

lathoub commented 3 years ago

Ha, i misunderstood you - thinking it related to the upcoming IDE v2, not the 2.0.0 release of the Arduino Mbed OS boards platform. My bad 🤦