search

lathoub / Arduino-USBMIDI

Allows a microcontroller, with native USB capabilities, to appear as a MIDI device over USB to a connected computer
MIT License
148 stars 11 forks source link

Incorrect CIN when sending system messages #8

Closed YuuichiAkagawa closed 3 years ago

YuuichiAkagawa commented 3 years ago

incorrectCIN https://github.com/lathoub/Arduino-USBMIDI/blob/3cc162d40acad4f0e2caf44acd4b8a4b303965d1/src/USB-MIDI.h#L76-L77 I think the second argument is cin.

 mPacket.header = MAKEHEADER(cableNumber, cin);
lathoub commented 3 years ago

Thanks @YuuichiAkagawa for spotting - if you make a PR, I happily accept

lathoub commented 3 years ago

fixed in PR #10 , thank you @YuuichiAkagawa