search

latinos / mkShapesRDF

A framework for post processing and shapes creation of CMS data.
https://mkshapesrdf.readthedocs.io/en/latest/index.html
1 stars 5 forks source link

l2kinproducer for PR to master #43

Open NTrevisani opened 1 month ago

NTrevisani commented 1 month ago

Please @BlancoFS, @mlizzo, and @dittmer have a look. I prepared this module, so I cannot review it :)

BlancoFS commented 3 weeks ago

Hi @NTrevisani,

In general, I would say it looks ready to merge. I don't see any missing variable with the exception of the mT2. Is this variable intended to be included? Could we just copy this function within the ROOT interpreter and run it on RDF?

Then, maybe this is not the right place to comment but I remember there was an implementation of the l3kin variables. Do we want to include it in the PR? (Or probably in a different PR)

NTrevisani commented 3 weeks ago

Hi @BlancoFS,

Thank you for the suggestions.

About mt2, I think we decided to avoid including it since it is not used anymore and it may add some time to compute it. Please @mlizzo and @dittmer comment on this if you have a different opinion.

I agree we should include also the l3kin and l4kin modules. I have to check if they are ready or not.