latinvm / orcid

WordPress plugin that displays ORCIDs in comments and posts
GNU General Public License v2.0
6 stars 3 forks source link

Duplication of trail text #5

Open pigsonthewing opened 10 years ago

pigsonthewing commented 10 years ago

From a comment on my blog:

Strange bug report for you. Over at http://occamstypewriter.org/ we syndicate the individual blogs’ feeds into the main page. While the ORCID plugin is active we get a duplication of the trail text. When it’s inactive everything works normally. We’re using FeedWordPress to syndicate, but I can’t actually remember how I configured the size of the posts it displays, so it might be a bit tricky to troubleshoot.

latinvm commented 10 years ago

This might also be cause by the way we inject ORCIDs. Perhaps requiring users to modify their templates is the way to go.

pigsonthewing commented 10 years ago

Again, I think that's a barrier to use (I've never modified a template and wouldn't know how to; I could find out, but others may not bother).

CAYdenberg commented 10 years ago

I suspect this is stemming from the option to insert ORCID at the end of the content, and is conflicting with whatever "Read more" plugin they use on occams typewriter. Just instinct, since I haven't looked over that part of the code carefully yet.

CAYdenberg commented 10 years ago

In the function below, the callbacks 'orcid_the_content_html' and 'orcid_the_content_html_position' don't seem to point anywhere.

function the_content_orcid($content){
    // get author's ORCID
    $orcid = $this->get_the_author_orcid();

    if ($orcid){
        // allow HTML override
        $html = sprintf(
            apply_filters('orcid_the_content_html','<div class="wp_orcid_post"><a href="http://orcid.org/%s" target="_blank" rel="author">%s</a></div>'),
            $orcid,
            $orcid
        );

        // allow position to be altered
        $html_position = apply_filters('orcid_the_content_html_position','top');
        if ($html_position == 'top') {
            return $html.$content;
        } else {
            return $content.$html;
        }
    } else {
        return $content;
    }
}

I removed them and it didn't affect behavior as far as I could tell. @pigsonthewing could you try downloading the code from my repo https://github.com/CAYdenberg/orcid and seeing if that solved it?

pigsonthewing commented 10 years ago

@CAYdenberg - I didn't experience the problem; someone who commented on my blog did. But I'll ask them to try it.