search

latitude-dev / latitude

Developer-first embedded analytics
https://latitude.so
GNU Lesser General Public License v3.0
670 stars 26 forks source link

Make source manager available to connectors. #384

Closed andresgutgon closed 2 weeks ago

andresgutgon commented 3 weeks ago

What?

For future changes, we need access to SourceManager from the connectors. With this change we be able to do this.source.manager inside the connectors

⚠️ ⚠️ ⚠️ Refactor ⚠️ ⚠️ ⚠️

I removed 🔥 @latitude-data/base-connector 🔥 and moved the code under @latitude-data/source-manager. I did this to avoid cyclic dependencies between all this code that is part of the same thing in the end.

Issue ticket number and link

Related with https://github.com/latitude-dev/latitude/issues/369

Checklist before requesting a review

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 446bf595ca402c1307863c6ad28606f578739275

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages | Name | Type | | ----------------------------------- | ----- | | @latitude-data/clickhouse-connector | Major | | @latitude-data/databricks-connector | Major | | @latitude-data/postgresql-connector | Major | | @latitude-data/snowflake-connector | Major | | @latitude-data/bigquery-connector | Major | | @latitude-data/athena-connector | Major | | @latitude-data/duckdb-connector | Major | | @latitude-data/sqlite-connector | Major | | @latitude-data/mssql-connector | Major | | @latitude-data/test-connector | Major | | @latitude-data/mysql-connector | Major | | @latitude-data/trino-connector | Major | | @latitude-data/source-manager | Major | | @latitude-data/cli | Minor | | @latitude-data/server | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

andresgutgon commented 3 weeks ago

I see a general agreement on not doing the setConnector. I'll try to do the spy instead