Fix: Automatic dark mode on Svelte - Githubissues

latitude-dev / latitude

Developer-first embedded analytics

https://latitude.so

GNU Lesser General Public License v3.0

719 stars 30 forks source link

Fix: Automatic dark mode on Svelte #412

Closed csansoon closed 1 month ago

csansoon commented 1 month ago

Describe your changes

Separated Storybook's ThemeWrapper (a menu for selecting the Theme, and the store where it's stored) and the actual ThemeProvider, which is used in the app.
Changed the class applied by ModeWatcher from dark to lat-dark, since the Tailwind prefix is applied to that class too.
Changed Tailwind's dark mode detection to selector, which identifies the dark class in the html element.
Disable chart animations when changing theme

https://github.com/latitude-dev/latitude/assets/57395395/439eccf2-3ad7-45d3-b009-03103451d809

Checklist before requesting a review

[ ] I have added thorough tests
[ ] I have updated the documentation if necessary
[x] I have added a human-readable description of the changes for the release notes
[x] I have included a recorded video capture of the feature manually tested

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: dc58c99e85e5d684944d6ec6f2010c6828a569be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

| Name | Type | | --------------------- | ----- | | @latitude-data/svelte | Minor | | @latitude-data/client | Patch | | @latitude-data/server | Patch | | @latitude-data/react | Patch | | example-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR