search

latitudegames / AIDungeon

Infinite adventures await!
http://www.aidungeon.io/
MIT License
3.19k stars 554 forks source link

[BUG] state of develop branch #154

Closed ben-bay closed 4 years ago

ben-bay commented 4 years ago

As of 2pm today I seem to have managed to stabilize develop, meaning the installation, torrenting, and gameplay all work on Colab with the branch changed to --branch develop.

I'm still trying to figure out why nested clones are appearing:

Screen Shot 2019-12-13 at 2 12 57 PM
dyc3 commented 4 years ago

This happens if you run all the cells in the notebook multiple times. Here's what happens:

On the first run,

  1. git clone repo
  2. cd AIDungeon
  3. install... etc

When you run the first cell again, it doesn't check the current directory. The current working directory is already ./AIDungeon. When git clone runs again, it doesn't care that it's already in a git repo, and it clones a new copy to ./AIDungeon/AIDungeon and then cds into that one.

ben-bay commented 4 years ago

@dyc3 lol embarassing if true.. I assumed it was that, but then upon exiting and revisiting a fresh notebook, the same thing occurred.

dyc3 commented 4 years ago

Does the filesystem state persist even if you completely reset the notebook or wait a while for the notebook to time out?

ben-bay commented 4 years ago

@dyc3 I'm closing this, I think I freaked out prematurely