latitudegames / AIDungeon

Infinite adventures await!
http://www.aidungeon.io/
MIT License
3.18k stars 556 forks source link

[BUG] Game will not run on Python 3.5 because of a couple f-strings #209

Closed cmazzullo closed 4 years ago

cmazzullo commented 4 years ago

🐛 Bug Report

Describe the bug Currently the game will not run on Python 3.5 due to a couple small compatibility issues. So far the only compatibility issues I found were a couple f-strings and a trailing comma in a function's arguments. The file install.sh specifies that Python 3.4 through 3.7 should work, and I'm assuming that you'd rather get rid of the incompatibilities than restrict the compatible versions further, so that's what I've done in the pull request associated with this issue.

How to Reproduce

  1. Install python 3.5
  2. Make a new virtualenv
  3. Run pip install -r requirements.txt
  4. Copy the folder containing the model data to generator/gpt2/models
  5. Run the game: python play.py
  6. Notice that it chokes on f-strings

Expected behavior I would expect the game to run after running "python play.py", which it does after applying this patch.