Make the login & register pages pretty

[GoogleCodeExporter]

In the web client, /auth/register or /auth/signin are really ugly. Make them 
look pretty. The pages are generated from templates in 
src/org/waveprotocol/box/server/gxp/AuthenticationPage.gxp and 
UserRegistrationPage.gxp.

Original issue reported on code.google.com by vega113 on 21 Oct 2010 at 3:16

[GoogleCodeExporter]

Login page starter project. I intend to take on this and make look the login 
page something like the one for Google Wave.

Original comment by vega113 on 21 Oct 2010 at 3:18

[GoogleCodeExporter]

Awesome, looking forward to your work.

Original comment by ano...@google.com on 21 Oct 2010 at 10:09

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Question regarding GXP: Is there some tutorial for handling conditional clauses 
(i.e. if then else) and for i18n with GXP? I checked the official GXP tutorial 
at http://code.google.com/p/gxp/wiki/Tutorial but couldnr find any examples for 
this.

Original comment by vega113 on 23 Oct 2010 at 11:23

[GoogleCodeExporter]

I made some progress. But it would be nice to get some input regarding the 
login/register pages visual design.
Here's the link to my waveinabox instance http://vegalabz.com:9898/

Original comment by vega113 on 23 Oct 2010 at 3:18

[GoogleCodeExporter]

Whoa that looks _so_ much better.

Thoughts:
- The login page looks good. My eyes keep expecting that blue bar up the top to 
go all the way to the right, though that would look a bit funky. Maybe try 
increasing the vertical space between the blue bar and the top of the page to 
be the same as the white space on the left and the right? ... It needs 
something.
- I would probably also space the page out a bit. Make the text a bit further 
away from the login box.
- I think the registration page looks too different from the login page, and it 
looks kinda asymmetrical. I take it you're still working on that one.

I feel your pain on the gxp documentation front. You can see an example of 
if-then in the LoginBar:

      <gxp:if cond='username == null'>
        <span class="loginbarrightmaintext">not logged in</span> |
        <a href="/auth/register">register</a> |
        <a href="/auth/signin?r=/">sign in</a>
      </gxp:if>

I don't know if there's a way to do else's. GXP certainly _does_ 
internationalization, but I'm not sure about documentation.

Original comment by jose...@gmail.com on 23 Oct 2010 at 10:52

[GoogleCodeExporter]

Thanks for feedback. I submitted a patch before I noticed it, Ok I ll try to 
make some changes as you described.

Original comment by vega113 on 24 Oct 2010 at 12:06

[GoogleCodeExporter]

I'm quite happy to take a patch now, and you can keep tweaking it. It by no 
means has to be perfect first go.

Original comment by jose...@gmail.com on 24 Oct 2010 at 12:38

[GoogleCodeExporter]

For GXP references take a look at: 
http://gxp.googlecode.com/svn/trunk/docs/gxp-ref.html.

Original comment by ljvderijk on 24 Oct 2010 at 1:11

[GoogleCodeExporter]

For the one line of text on the login page, the first thing users will see, 
let's have something a bit more immediate.

How about: "Wave in a Box is an open source Wave system".

I'm sure we can come up with more later, and in fact this is probably something 
that app administrators should be able to configure.

Original comment by ano...@google.com on 24 Oct 2010 at 11:57

[GoogleCodeExporter]

But it doesn't say what is "Wave". But I agree that this issue should be looked 
into. Maybe we need to have an open discussion or vote for this. 

Original comment by vega113 on 25 Oct 2010 at 9:19

[GoogleCodeExporter]

I made some changes to the login page - made it look more like GMail one. 
Regarding user registration page - I agree - it can be made to look better, 
however it also follows the style of the gmail registration. If someone can 
give constructive suggestions on how to improve it - I ll be glad.
The preview is at my instance - vegalabz.com:9898. 

Original comment by vega113 on 25 Oct 2010 at 11:30

[GoogleCodeExporter]

"Wave lets you communicate and collaborate in real time".

Anyway, this is such a great improvement I'm in favour of submitting this as-is 
and then continuing to iterate in new changes.

Original comment by ano...@google.com on 25 Oct 2010 at 10:38

[GoogleCodeExporter]

I think that "Wave" is too ambiguous, it has too many meanings. Anyway, I 
submitted 3-rd patch set with more fixes for review.

Original comment by vega113 on 29 Oct 2010 at 1:13

[GoogleCodeExporter]

The patch is in, so should be marked as "closed"

Original comment by vega113 on 4 Nov 2010 at 6:59

[GoogleCodeExporter]

Original comment by ljv@google.com on 4 Nov 2010 at 7:02

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by jose...@gmail.com on 4 Nov 2010 at 11:20

• Changed state: Done

[GoogleCodeExporter]

Original comment by ljv@google.com on 4 Nov 2010 at 11:23

• Changed state: Fixed