latos / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

Console Client doesn't connect #142

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. ./run-server.sh
2. ./run-console-client.sh

What is the expected output? What do you see instead?
The expected output is a request for a password. However with the recent change 
to HTTP_SERVER_PUBLIC_ADDRESS the Console client cannot connect for two 
reasons. Firstly it's still looking for the web socket address, and secondly it 
takes the address and port as seperate variables.

I've attached three patches to this which solves the problem.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by JamesRPu...@gmail.com on 4 Nov 2010 at 12:57

Attachments:

GoogleCodeExporter commented 8 years ago
Hi James, would you mind submitting these patches using the review tool :). 
Thanks!

Original comment by ljv@google.com on 4 Nov 2010 at 6:15

GoogleCodeExporter commented 8 years ago

Original comment by ljv@google.com on 4 Nov 2010 at 6:15

GoogleCodeExporter commented 8 years ago
James, thanks for reporting this. I think it would be better to not change 
run-config.sh and instead let the client take $HTTP_SERVER_PUBLIC_ADDRESS as a 
single argument. See:
http://codereview.waveprotocol.org/291001/show

Original comment by so...@google.com on 4 Nov 2010 at 7:46

GoogleCodeExporter commented 8 years ago
This issue was closed by revision 8cc0bf7f71.

Original comment by so...@google.com on 4 Nov 2010 at 7:52