latos / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

Incorrect transform for annotations #144

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Randomized testing exposed an error in the transform of annotation boundaries.

@@ -39,7 +39,7 @@ public class DocumentDomainTest extends TestCase {

   public void testTransform() {
     createTester();
-    t.testTransformDiamondProperty(NUM_ITERATIONS);
+    t.testTransformDiamondProperty(70 * NUM_ITERATIONS);
   }

@@ -269,7 +269,7 @@ public class DomainRandomTester<D, O> {

   public void testTransformDiamondProperty(int numIterations) {
     log.info("TESTING testTransformDiamondProperty");
-    Random r = new Random(0);
+    Random r = new Random(5234);

....
Iteration: 169
Iteration: 170
Iteration: 171
org.waveprotocol.wave.model.operation.OperationException: Validation failed: 
ViolationCollector[1: invalid operation: new annotation value incorrect for 
deletion at original document position 430 / resulting document position 442]
       at org.waveprotocol.wave.model.document.bootstrap.BootstrapDocument.consume(BootstrapDocument.java:348)
       at org.waveprotocol.wave.model.operation.testing.DocumentDomain.apply(DocumentDomain.java:25)
       at org.waveprotocol.wave.model.operation.testing.DocumentDomain.apply(DocumentDomain.java:16)
       at org.waveprotocol.wave.model.operation.testing.DomainRandomTester.testTransformDiamondProperty(DomainRandomTester.java:301)
       at org.waveprotocol.wave.model.operation.testing.DocumentDomainTest.testTransform(DocumentDomainTest.java:42)
       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
       at java.lang.reflect.Method.invoke(Method.java:616)
       at junit.framework.TestCase.runTest(TestCase.java:168)
       at junit.framework.TestCase.runBare(TestCase.java:134)
       at junit.framework.TestResult$1.protect(TestResult.java:110)

Original issue reported on code.google.com by ano...@google.com on 6 Nov 2010 at 7:37

GoogleCodeExporter commented 8 years ago
We have determined this to be a bug in transform and have a fix in development.

Original comment by ano...@google.com on 6 Nov 2010 at 7:37

GoogleCodeExporter commented 8 years ago

Original comment by ljv@google.com on 6 Nov 2010 at 7:42

GoogleCodeExporter commented 8 years ago
Is it still an issue or was already fixed?

Original comment by vega113 on 27 Feb 2011 at 9:47

GoogleCodeExporter commented 8 years ago
It's still an issue and the fix is still in development. I'm trying to wrap 
this up and will provide an update next week.

Original comment by so...@google.com on 28 Feb 2011 at 2:27

GoogleCodeExporter commented 8 years ago
This issue was closed by revision 585ca8b86f58.

Original comment by so...@google.com on 7 Apr 2011 at 5:17