latos / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

inserting letters with acute accents as password makes the server crash #185

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Click "Register a new account".
2. Type a user-name.
3. Type a password containing letters with acute accents.
    example: "á", "áéíóú"
4. Click "Register".

or

5. Type a user-name.
6. Type a password like one of the above.
7. Click "Sign In"

What is the expected output? What do you see instead?
I expected an alert saying that you can't use those characters (when I first 
registered the password), or that I can sign in successfully to my 
newly-created account.

What I see is
HTTP ERROR: 500

Problem accessing /auth/register. Reason:

    !utf8

What changeset or version are you using? On what operating system?
changeset - 766:88951b7f1ff1
Archlinux 64bit.

Original issue reported on code.google.com by jaosorior on 20 Dec 2010 at 2:17

GoogleCodeExporter commented 8 years ago
Joseph, any chance you could take a look? Assign back to me if not.

Original comment by ano...@google.com on 20 Dec 2010 at 3:19

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
nevermind the deleted comments.

Original comment by jaosorior on 20 Dec 2010 at 3:25

GoogleCodeExporter commented 8 years ago
Oh, jaosorior, if you would like to fix it please do! I can't assign the issue 
to you due to a technical limitation of this tracker, but go for it!

Original comment by ano...@google.com on 20 Dec 2010 at 3:33

GoogleCodeExporter commented 8 years ago
alright, fixed. To whom should I send the code to be reviewed?

Original comment by jaosorior on 23 Dec 2010 at 6:21

GoogleCodeExporter commented 8 years ago
here's the patch: http://codereview.waveprotocol.org/450001

Original comment by jaosorior on 23 Dec 2010 at 7:37

GoogleCodeExporter commented 8 years ago

Original comment by ano...@google.com on 24 Dec 2010 at 5:25