latos / wave-protocol

Automatically exported from code.google.com/p/wave-protocol
0 stars 0 forks source link

Make resourceBase configurable in ServerRpcProvider #230

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
For projects that don't use the "war" directory and integrate WIAB is useful to 
make this configurable.

For instance in projects that use maven, can be "target":
 http://googlewebtoolkit.blogspot.com/2010/08/how-to-use-google-plugin-for-eclipse.html

I'll send a code review with a small patch

Original issue reported on code.google.com by vruiz.ju...@gmail.com on 26 Feb 2011 at 1:00

GoogleCodeExporter commented 8 years ago
http://codereview.waveprotocol.org/552001  (I'v picked vega113 as reviewer but 
please reassign it if necessary)

Original comment by vruiz.ju...@gmail.com on 26 Feb 2011 at 1:16

GoogleCodeExporter commented 8 years ago
http://codereview.waveprotocol.org/552002 a better patch with resource base 
allowing multiple source dirs (useful for WIAB integrations):
http://docs.codehaus.org/display/JETTY/Multiple+WebApp+Source+Directory

Original comment by vruiz.ju...@gmail.com on 26 Feb 2011 at 6:37

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Sorry Vega, and thanks... Can you delete your comment? (for prevent spamming to 
their accounts)

Original comment by vruiz.ju...@gmail.com on 27 Feb 2011 at 12:12

GoogleCodeExporter commented 8 years ago
Yuri, I'll appreciate if you will review the patch (no need to be a committer 
to review code). I'm happy to apply the patch after review. I may throw in some 
additional review comments but I don't know this aspect of the code very well.

Original comment by so...@google.com on 27 Feb 2011 at 12:33

GoogleCodeExporter commented 8 years ago
Ok, deleted the previous comment. Sure I ll look into the code. 

Original comment by vega113 on 27 Feb 2011 at 1:14

GoogleCodeExporter commented 8 years ago
This issue was closed by revision 0b14aa7ad1.

Original comment by so...@google.com on 2 Mar 2011 at 11:09