Closed bjoo closed 1 year ago
@bjoo thanks for the fix.
Note it was intentional to include the C complex header not the C++ one, since the QUDA interface is C based. This test might not even need this header at all though?
Reminds me that we should clean up headers using IWYU at some point.
Turns out it wasn't needed. I commented it and the code compiled fine. So I just ended up removing it. Makes for a cleaner PR
Just noting that this issue was a gtest issue which has since been fixed. We should update the version of gtest we package with QUDA, or perhaps use CPM if it's available?
@bjoo Thanks for this. Also hit it recently but didn't get around to figuring out where it was coming from.
To avoid a #define conflict between and gtest.h when using hipcc compiler. This fixes a local issue Venkitesh Ayyar raised on Crysger at OLCF which prevented
gauge_path_test.cpp
from compiling with the following #define clash:Also I changed from
#include <complex.h>
to the more C++#include <complex>