Hotfix/cmake housekeeping

lattice / quda

QUDA is a library for performing calculations in lattice QCD on GPUs.

https://lattice.github.io/quda

Other

289 stars 97 forks source link

Hotfix/cmake housekeeping #1345

Closed mathiaswagner closed 1 year ago

mathiaswagner commented 1 year ago

update CPM use more of FindCUDAToolkit and remove legacy workarounds use NVTX3 (and drop support for legacy NVTX) removed unused NVML stuff

maddyscientist commented 1 year ago

Looks good to me. Only thought is if we want to remove the driver version reporting with NVML. That might be something we should be doing by default?

mathiaswagner commented 1 year ago

It looked to me like enabling that from cmake was broken. Happy to make it the default.

maddyscientist commented 1 year ago

It may well have been, it's been a while since I tried it. 😄 NVML is something we should always link to anyway I think, since it has a multitude of uses.

mathiaswagner commented 1 year ago

Thanks. The missing system is a bit weird. At some point we should try to get to using an updated version of CLI11 but that is not high priority for now.