search

lattice / quda

QUDA is a library for performing calculations in lattice QCD on GPUs.
https://lattice.github.io/quda
Other
279 stars 94 forks source link

Tuning behavior is dependent on verbosity setting #1358

Open maddyscientist opened 1 year ago

maddyscientist commented 1 year ago

@jcosborn I just noticed an issue with your PR #1353 that has me confused. Specifically, on this line, error is only set if the verbosity is set to QUDA_DEBUG_VERBOSE. Is this a bug? We shouldn't have behavior like this dependent on the verbosity setting.

jcosborn commented 1 year ago

The goal was to make sure to print out the last error string if we end up here. If verbosity >= QUDA_DEBUG_VERBOSE then we would have already printed it out above, so I didn't bother to print it again (plus we would need to save it since it gets reset). We could save it above and print it again if that is preferred.