search

lattice / quda

QUDA is a library for performing calculations in lattice QCD on GPUs.
https://lattice.github.io/quda
Other
289 stars 97 forks source link

Commended out hipDeviceSetCacheConfig call #1360

Closed bjoo closed 1 year ago

bjoo commented 1 year ago

In a recent ROCm, this call stopped returning hipSuccess. Since we check the error code, it basically stops the code from running right at the outset. I am commenting it out here. I am told it will be fixed in a future ROCm, but actually I am not sure if it does anything in the first place.

kostrzewa commented 1 year ago

Thanks! I bumped into this on LUMI-G with ROCm > 5.2.x but didn't want to bother you without first checking with our contacts there, which I haven't gotten around to yet. Good to know that we can test with newer versions without worrying about this.

bjoo commented 1 year ago

@kostrzewa can you please approve this PR in your role in target_hip_maintainers? I cannot approve my own PR....

kostrzewa commented 1 year ago

@bjoo should I push the button?