Closed agrebe closed 1 year ago
Jenkins: Can one of the admins verify this patch?
Jenkins: Can one of the admins verify this patch?
@Jenkins Ok to test
Thanks for the PR @agrebe. Regarding the profiling issue: this is actually fixed in my WIP branch which overhauls the profiling somewhat and prevents issues like this from happening. Regardless, my PR will likely take a week or two until it's merged, so I'm happy to merge in your fix for now.
Before I hit merge (likely tomorrow), please feel free to add your name to the contributor list in the README.
If it's okay, I've added both myself and Michael Wagman to the contributors list since we were pair programming when we discovered the bug and implemented the fix. (Yi-Bo Yang also deserves most of the credit, but he's already on the contributor list.)
Also, I just want to thank you @maddyscientist and all the developers for all your hard work on QUDA -- this is really great software and indispensable to our computations!
All good with adding both of you. I'll merge once the CI builds complete.
This is a modification to lib/interface_quda.cpp to fix the two bugs described by Yi-Bo Yang in issue #681: