search

lattice / quda

QUDA is a library for performing calculations in lattice QCD on GPUs.
https://lattice.github.io/quda
Other
287 stars 94 forks source link

Add some sanity checking on the CPM.cmake download #1397

Closed dmcdougall closed 1 year ago

dmcdougall commented 1 year ago

It's possible for this download to fail. An example failure scenario is when CMake is not built with OpenSSL support, and so the https protocol is not supported.

After this change, when it fails the user will be informed:

  1. that it actually failed, as opposed to silently continuing with an empty CPM.cmake file; and
  2. why CMake thinks the failure happened.
mathiaswagner commented 1 year ago

Jenkins: Can one of the admins verify this patch?

mathiaswagner commented 1 year ago

Jenkins: Can one of the admins verify this patch?

mathiaswagner commented 1 year ago

This file is included following the instructions from https://github.com/cpm-cmake/CPM.cmake#adding-cpm and potentially overwritten when updating CPM. I am hesitant to modify the version that comes with QUDA for that reason. Maybe this can be addressed directly in CPM?

mathiaswagner commented 1 year ago

Maybe this is addressing it already ?

dmcdougall commented 1 year ago

Ah, thanks. I didn't realise it came from upstream CPM.

mathiaswagner commented 1 year ago

Might still be worth having an issue to track this.