Closed alexstrel closed 2 months ago
Glad you got this pull request opened @alexstrel and @james-simone. Once you get the CI tests to pass we can proceed to reviewing it.
Thank you @maddyscientist for comments and suggestions.
what was the purpose of the method at
https://github.com/lattice/quda/blob/feature/staggered_correlators/include/color_spinor_field.h#L789
It seems that the only place where it was supposed to be used is
https://github.com/lattice/quda/blob/feature/staggered_correlators/lib/vector_io.cpp#L358
but it is itself a commented code.
Besides, it looks like that downPrec
is now an abandoned function, so my suggestion is to delete it.
@alexstrel regarding ColorSpinorField::CreateAlias
, it has been superseded by ColorSpinorField::create_alias
, and as you point out it's not now used anywhere. So I think we can just delete both CreateAlias
and downPrec
as you suggest.
@alexstrel have the contraction kernels been testing running on multiple GPU, when partitioning the XYZ dimension? Looking at the code, I'm not sure that this case is properly supported.
This PR primarily adds an extension to the QUDA contraction code for staggered fermions. To utilize this, a new parameter,
QUDA_CONTRACT_TYPE_STAGGERED_FT_T
, has been introduced. The main application for testing this is contractFT_test.cpp.