search

lattice / quda

QUDA is a library for performing calculations in lattice QCD on GPUs.
https://lattice.github.io/quda
Other
287 stars 94 forks source link

Add more ROCm versions to CI #1419

Closed dmcdougall closed 9 months ago

dmcdougall commented 9 months ago

Let's see if this works... :)

maddyscientist commented 9 months ago

@dmcdougall I see the inline assembly warnings are now gone with 5.6. Is there any reason to keep around 5.5 or can we dump this and make the builds STRICT now?

dmcdougall commented 9 months ago

Is there any reason to keep around 5.5 or can we dump this and make the builds STRICT now?

You took the wind out of my sails :)

That is indeed my next step, I just wanted to sanity check the multiple version infrastructure did what I expected it to do.

Don't merge this yet; I'll update this PR with more commits.

dmcdougall commented 9 months ago

@maddyscientist Can you kick off another build please?

dmcdougall commented 9 months ago

Hmmm, these STRICT builds succeeded but there are still warnings. I'll dig.

dmcdougall commented 9 months ago

Oh this turns off the error (STRICT users -Werror). It doesn't turn off the warning.

maddyscientist commented 9 months ago

@dmcdougall good to merge now from your point of view?

dmcdougall commented 9 months ago

Yep. Thanks.