search

lattice / quda

QUDA is a library for performing calculations in lattice QCD on GPUs.
https://lattice.github.io/quda
Other
279 stars 94 forks source link

Turn on domain wall builds #1460

Closed dmcdougall closed 2 months ago

dmcdougall commented 2 months ago

Fixes #1440.

maddyscientist commented 2 months ago

@dmcdougall I see domain wall fails to build with ROCm 5.7.2. What do you suggest to do here?

dmcdougall commented 2 months ago

I expected that. Someone (I think it might have been Balint) reported this problem to me in an email, and the reason we didn't catch it is because it was in the domain wall piece, which I didn't have enabled.

The summary is that I already know about this failure and I have a ticket open internally to fix it.

If you don't want noisy failures showing up in other PRs, it's probably a good idea to leave this unmerged until it's fixed in the ROCm stack.

dmcdougall commented 2 months ago

Er, wait, my memory sucks. This failure is with 5.7.2, and I believe this was fixed in 6.0.2. I'll replace the 5.7.2 workflow with the 6.0.2 workflow and see what happens. If it's all green there then I'll probably just drop the 5.7.2 from the workflow.

maddyscientist commented 2 months ago

@dmcdougall looks like v6 works fine, so I guess we can merge this and move on?

dmcdougall commented 2 months ago

@maddyscientist Agree