search

latticexyz / mud

MUD is a framework for building autonomous worlds
https://mud.dev
MIT License
711 stars 177 forks source link

ci: add timeout to e2e tests #2768

Closed roaminro closed 4 months ago

roaminro commented 4 months ago

This PR add a timeout of 25 minutes to the e2e tests. After looking at the history of the e2e tests runs, I saw that it usually takes 8-12 minutes to complete these tests so I arbitrarly chose 25 minutes which is approximately 2x of the max runtime observed.

Let me know if you feel that 25 minutes is still too high.

Closes #2761

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 39ef8ec23aca7cdc3488fce1e09a349d9f176c68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

holic commented 4 months ago

thank you! just a small suggestion to time out the exact thing that was stalling

roaminro commented 4 months ago

Thanks for the review, just pushed the changes ;)