latticexyz / mud

MUD is a framework for building autonomous worlds
https://mud.dev
MIT License
696 stars 175 forks source link

chore: don't use linked deps in example #2820

Closed qbzzt closed 2 months ago

qbzzt commented 2 months ago

The dependencies in this example used to point to the rest of the repository:

  "dependencies": {
    "@latticexyz/common": "link:../../../../packages/common",
    .
    .
    .
  }

However, this causes a problem when users don't need to build the whole repository (see https://discord.com/channels/865335009915961364/1239515132917186600).

Using latest instead solves this problem.

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 8bfc5cdf8446d8df81f23c9188a1ff966715b6a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

holic commented 2 months ago

can you fill in the PR description with a bit of an explanation of why we're making this change?

qbzzt commented 2 months ago

can you fill in the PR description with a bit of an explanation of why we're making this change?

Sorry I haven't done it last night. Updated.