search

latticexyz / mud

MUD is a framework for building autonomous worlds
https://mud.dev
MIT License
725 stars 183 forks source link

fix hanging test #2826

Closed holic closed 4 months ago

holic commented 4 months ago

(from https://github.com/latticexyz/mud/pull/2823#issuecomment-2111072372)

packages/store-sync test:ci: close timed out after 500ms
packages/store-sync test:ci: Failed to terminate worker while running /home/runner/work/mud/mud/packages/store-sync/src/recs/recsStorage.test.ts.
packages/store-sync test:ci: Tests closed successfully but something prevents Vite server from exiting
packages/store-sync test:ci: You can try to identify the cause by enabling "hanging-process" reporter. See https://vitest.dev/config/#reporters

maybe related: https://github.com/vitest-dev/vitest/issues/3077 https://github.com/nodejs/undici/issues/2026#issuecomment-2000017934

sounds like maybe bumping to node >=18.20.1 could fix the above

in the meantime, we can add some CI timeouts like in #2768 to ensure this doesn't run longer than it should

holic commented 4 months ago

node bumped and timeout added in https://github.com/latticexyz/mud/pull/2836