latticexyz / mud

MUD is a framework for building autonomous worlds
https://mud.dev
MIT License
724 stars 181 forks source link

In `mud verify`, don't give me an Etherscan URL when irrelevant #2875

Open qbzzt opened 4 months ago

qbzzt commented 4 months ago

I verified a contract on Blockscout:

qbzzt@Oris-MacBook-Pro contracts % pnpm mud verify --worldAddress 0x40cc08060341a8449d0906fb5daf3cc1bf996b05 --rpc $ETH_RPC_URL --verifier blockscout --verifier-url https://eth-holesky.blockscout.com/api 
(node:55480) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

 Verifying MUD contracts to RPC https://ethereum-holesky-rpc.publicnode.com 

  mud:cli:deploy found CREATE2 deployer at 0x4e59b44847b379578588920ca78fbf26c0b4956c +0ms
running "forge verify-contract 0xB9A596A532AD582f80E6f88Aa4ec48c492749A11 TasksSystem --rpc-url https://ethereum-holesky-rpc.publicnode.com --verifier blockscout --verifier-url https://eth-holesky.blockscout.com/api"

Note: MUD is currently unable to verify store, world, and world-modules contracts with blockscout. We are planning to expand support in a future version.

Start verifying contract `0xB9A596A532AD582f80E6f88Aa4ec48c492749A11` deployed on holesky

Submitting verification for [src/systems/TasksSystem.sol:TasksSystem] 0xB9A596A532AD582f80E6f88Aa4ec48c492749A11.
Submitted contract for verification:
    Response: `OK`
    GUID: `b9a596a532ad582f80e6f88aa4ec48c492749a116654e1c4`
    URL: https://holesky.etherscan.io/address/0xb9a596a532ad582f80e6f88aa4ec48c492749a11

Why do I get the etherscan URL? The blockscout one, https://eth-holesky.blockscout.com/address/0xB9A596A532AD582f80E6f88Aa4ec48c492749A11 , in a lot more useful.

ludns commented 3 weeks ago

This is a Foundry issue