feat: restore typesVersions

latticexyz / mud

MUD is a framework for building autonomous worlds

https://mud.dev

MIT License

692 stars 174 forks source link

feat: restore typesVersions #2878

Closed holic closed 1 month ago

holic commented 1 month ago

closes https://github.com/latticexyz/mud/issues/2871

for backwards compatibility with moduleResolution: "node" we had removed this in https://github.com/latticexyz/mud/pull/2828 but it broke projects when upgrading MUD verisons

(intentionally didn't include a changeset because this can be considered part of the changes in https://github.com/latticexyz/mud/pull/2828 and https://github.com/latticexyz/mud/pull/2873)

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: a28149e65c13a765ef0be398cdb4fbf33add35c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

holic commented 1 month ago

confirmed this works in templates by

creating a project using mud latest (doesn't yet have these TS changes)
upgrading mud to tag main
checking that there are type errors
upgrading mud to tag restore-typeversions

checking that there are no type errors and the project can be built and IDE can resolve imports

pnpm create mud@latest test-project-types
cd test-project-types
pnpm mud set-version --tag main && pnpm install
pnpm mud set-version --tag restore-typeversions && pnpm install