move away from `peerDependencies`

latticexyz / mud

MUD is a framework for building autonomous worlds

https://mud.dev

MIT License

721 stars 180 forks source link

move away from `peerDependencies` #411

Closed holic closed 1 year ago

holic commented 1 year ago

Some MUD packages depend on other MUD packages via peerDependencies, but the versions aren't incremented when we release (and looks like lerna doesn't want to change this), so we should figure out another approach to keep things in sync.

[x] ecs-browser
[x] network
[x] noise
[x] phaserx
[x] react
[x] recs
[x] solecs
[x] std-client
[x] utils

holic commented 1 year ago

Separately, I kinda hate how much time I spend fighting/updating peerDependencies and maybe we should consider doing regular dependencies and eating the cost of big packages.

holic commented 1 year ago

With #660, we've started moving away from peer dependencies. Let's keep this going!

holic commented 1 year ago

@alvrs in a world where we have regular deps instead of peer deps, what are the new conditions under which we might still want peer deps? I'm happy to take a clean up pass on this, just wanna know when we should be using peer deps.