laudrup / boost-wintls

Native Windows TLS stream wrapper for use with Asio
https://wintls.dev
Boost Software License 1.0
55 stars 13 forks source link

add shutdown test cases #74

Closed jens-diewald closed 1 year ago

jens-diewald commented 1 year ago

This should not be merged in the current state but is rather supposed to show of a difference between Asio.SSL and WinTLS: Asio will produce a stream_truncated error on shutdown, if the remote did not properly shut down the protocol while WinTLS will not.

Note https://stackoverflow.com/questions/25587403/boost-asio-ssl-async-shutdown-always-finishes-with-an-error

Also, according to that post, Asio should produce an error if it initiated the shutdown and it goes through without problem. This does not seem to be the case (anymore?). This is relevant for the https examples in WinTLS. Currently the https async example handles asio::error::eof (as do the beast examples async+sync), while the sync example does not.

laudrup commented 1 year ago

Thanks for looking into this.

I'll be happy to merge this once it's done.

jens-diewald commented 1 year ago

I close this in favor of #78