laudrup / boost-wintls

Native Windows TLS stream wrapper for use with Asio
https://wintls.dev
Boost Software License 1.0
55 stars 13 forks source link

Use ANSI functions explicitly #85

Closed computerquip-work closed 3 months ago

computerquip-work commented 5 months ago

A simple attempt at fixing the issues with UNICODE. I've not removed the countermeasures already implemented.

Work towards: https://github.com/laudrup/boost-wintls/issues/84

laudrup commented 5 months ago

Looks like how this should have been done initially. Thanks a lot.

If you remove the ugly #ifdef UNICODE stuff I had written initially I think this could be merged.

There's already a job for testing with UNICODE defined. You might consider extending that so it fails with the current implementation (ie. the headers are included with UNICODE defined before including wintls) but it's not all that important.

laudrup commented 3 months ago

Sorry, I had completely forgotten about this