laughedelic / atom-ide-scala

:atom: Scala & Dotty support for Atom IDE (🧟‍♂️ zombie repo)
https://atom.io/packages/ide-scala
MIT License
48 stars 10 forks source link

New Metals #69

Closed laughedelic closed 5 years ago

laughedelic commented 5 years ago

This is targeting Metals v0.2.0. Metals integration just works™, but there are still some warts on the Atom side of this integration.

Metals LSP extensions:

Other things to do before merging it:

cquiroz commented 5 years ago

👍

laughedelic commented 5 years ago

I implemented simple rendering for the Metals Doctor output, but it's not pretty:

screenshot 2018-12-02 at 04 46 08

I don't know how to fix it right now (should I add some CSS somewhere? or a different kind of view container?), so I'm going to merge it as is and improve it later.

olafurpg commented 5 years ago

It doesn't look any nicer in vscode. We can maybe ads some padding in the provided html but we'd need to make sure it looks OK in vscode, atom and the http client.