Closed laughedelic closed 5 years ago
👍
I implemented simple rendering for the Metals Doctor output, but it's not pretty:
I don't know how to fix it right now (should I add some CSS somewhere? or a different kind of view container?), so I'm going to merge it as is and improve it later.
It doesn't look any nicer in vscode. We can maybe ads some padding in the provided html but we'd need to make sure it looks OK in vscode, atom and the http client.
This is targeting Metals v0.2.0. Metals integration just works™, but there are still some warts on the Atom side of this integration.
Metals LSP extensions:
metals/didFocus
metals/status
: shows messages in the status barmetals/slowTask
: cannot implement it, because atom-languageclient currently doesn't allow to add custom request handlers (only notifications). I will fix it upstream, but IMO it would be nice if Metals was a bit more flexible on this and could (as an option) send a normalshowMessageRequest
with a cancel button and no ticking timer.Other things to do before merging it:
metals/status
in the busy-signal and see if it looks betternone
server (which is a hack and always causes problems).