search

laughedelic / gtm

:stopwatch: git task/time manager
86 stars 10 forks source link

Starting timer from non-root dir sets wrong repo path #46

Closed laughedelic closed 11 years ago

laughedelic commented 11 years ago

I reproduced the bug and I think that the problem is very simple: when you start a timer from non-git-root directory, it is written to git config --global timetracker.repo, and then gtm tries to use it in post-commit hook. Fixing it tomorrow.

laughedelic commented 11 years ago

@eparejatobes, try to update to current 0.3.4 version — I'm not completely sure, but I think I resolved this problem. Tell me please, if you still have it.

eparejatobes commented 11 years ago

@laughedelic thanks for the fix; tested it and now the time spent is correctly set. However, the timer keeps running afterwards; is this by design, or a bug?

laughedelic commented 11 years ago

It is by design. set shouldn't change state of timer (it stops it and re-runs, if it was running). In gtt it was called hacking mode — in gtm it is default and the only, because this way you don't need to re-run timer constantly and you don't loose time between commits and etc. But if it changed state of timer — it's not normal.