search

laughingman7743 / PyAthena

PyAthena is a Python DB API 2.0 (PEP 249) client for Amazon Athena.
MIT License
456 stars 102 forks source link

URLLIB3 / Requests #535

Closed VeNoMouS closed 2 months ago

VeNoMouS commented 2 months ago

Can we get rid of your outdated urrlib3 etc from requirements if botocore is now using newer versions, since you already require botocore why not let them dictate required modules since you dont import urllib3 / requests yourself...

you're killing me with having to do forced updates after your package updates.

laughingman7743 commented 2 months ago

https://github.com/laughingman7743/PyAthena/blob/master/pyproject.toml#L7-L12 This library has no direct dependencies with urllib3.

VeNoMouS commented 2 months ago

Then why include them https://github.com/laughingman7743/PyAthena/blob/master/requirements/requirements.txt#L921 as requirements

laughingman7743 commented 2 months ago

That's a dependency of the environment for developing this library. This library has no direct urllib3 or requests dependencies. https://github.com/laughingman7743/PyAthena/blob/master/pyproject.toml#L83-L101

laughingman7743 commented 2 months ago

https://github.com/boto/botocore/blob/develop/setup.py#L25-L33 botocore has a dependency on urllib3; it would be good to ask botocore to improve it.