search

laullon / gitx

GitX (L) - A gitk clone for OS X
http://gitx.laullon.com/
Other
836 stars 76 forks source link

Submit a patch for a defect which file link jump fails in GitX (L) #207

Open johnnytemp opened 12 years ago

johnnytemp commented 12 years ago

Dear laullon,

I found and fixed a small bug in GitX (L) that "file link" in changes-of-a-commit view cannot jump, in case if a file's path has "b/" pattern.

See whether you would like to apply it to your project.

Here is it:

line 464 of file /GLFileView.m, based on commit : 23c99a76a457fe9b191676fcc0b70778142fe7f3

--- 464 NSRange b = [line rangeOfString:@"b/"]; +++ 464 NSRange b = [line rangeOfString:@" b/"]; // Fixed @"b/" to @" b/"

Sorry for my disturbance.

Yours sincerely, Johnny Wong.

johnnytemp commented 11 years ago

To make it clear, for example: your project folder is named "xxb", when you view any commit histories which contains changes for some files inside folder "xxb", clicking on the hyper-link of those files cannot jump to the corresponding change.

Johnny

jasonkarns commented 11 years ago

:+1: This :bug: has been bugging me for a while.