I was actually going to contribute a bit more to GLC_Player, but now that I've worked with the codebase I won't be doing this. This PR is left in an unfinished state too.
I'd consider this PR unmergeable - it has to be cleaned and the same step should be done for all other libraries too.
The following is supposed to be constructive criticism, because I care a lot about GLC_Player, and I have been using it a lot over the past years.
Reasons for not contributing to GLC_Player for me include:
Unclear license state
Ecosystem being bad (see my issue about this) and lack of deployment / integration with distributions or OS (there should be CI with new builds being deployed)
Lack of guidance / little documentation (for starters, see my issue about the README)
Broken state of the repos (GLC_Player master not compatible with GLC_lib master)
Bad english spelling in the source code, including variable names
Frankenstein-ed libraries which is recipe for disaster (and could be a security risk)
The qmake build system
Self-made code where libraries should be used instead (either assimp or stuff like OpenCollada)
Resulting lack of features
Ugly and dangerous code in various spots (such as normal calculation in Collada loader treating vertex position and normal arrays as scalar float arrays - this suggests that GLC_Mesh is already poorly designed)
These are the major issues and I hope you'll realize their significance and fix those things in the future, possibly a full rewrite.
I'm quite sad about this, because I have been using GLC_Player for what feels like an eternity.
However, now that I need new features and saw the underlying code, I will be looking for a different tool - not only for development, but also as a user.
This (theoretically) solves the issue I've discussed in https://github.com/laumaya/GLC_Player/issues/6#issuecomment-386920729
I was actually going to contribute a bit more to GLC_Player, but now that I've worked with the codebase I won't be doing this. This PR is left in an unfinished state too. I'd consider this PR unmergeable - it has to be cleaned and the same step should be done for all other libraries too.
The following is supposed to be constructive criticism, because I care a lot about GLC_Player, and I have been using it a lot over the past years.
Reasons for not contributing to GLC_Player for me include:
These are the major issues and I hope you'll realize their significance and fix those things in the future, possibly a full rewrite.
I'm quite sad about this, because I have been using GLC_Player for what feels like an eternity. However, now that I need new features and saw the underlying code, I will be looking for a different tool - not only for development, but also as a user.