launchableinc / cli

Launchable CLI
https://pypi.org/project/launchable/
Apache License 2.0
24 stars 13 forks source link

Error check improvement #857

Closed kohsuke closed 6 months ago

kohsuke commented 6 months ago

An experienced customer experiemented with the CLI locally to try out a new command. Upon seeing the --session option, they assumed they just need to pass a test session ID, so they ended up invoking something like launchable foo bar --session 12345

That is a good assumption on their part, but it's actually incorrect, as the ID format we take is more complicated. However, there's no error check, so the CLI resulted in 404, which misled them.

By adding parse_session, we can make sure the ID given from the command line is in the correct format, and fail gracefully if not.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud