[ENG-524] update the --branch option behavior to start collecting lineage for builds

kohsuke commented 1 month ago

See the linked design document for more details.

Summary by CodeRabbit

Release Notes

New Features
- Enhanced clarity and robustness in session and build management commands.
- Introduced alias functionality for command groups.
- Improved handling of command-line options for flavors and links.
Bug Fixes
- Refined error messages for session name validation and flavor input.
- Adjusted payload handling for Git submodules and commit options.
Tests
- Expanded test coverage for build recording and session commands.
- Added new tests for the KEY_VALUE type functionality.

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes encompass updates to function signatures, type annotations, and internal logic across multiple files in the launchable project. The modifications primarily focus on enhancing the clarity of command-line options, improving error handling, and refining the processing of session and build management functionalities. Notably, the handling of key-value pairs has been standardized, and several tests have been adjusted to reflect these changes.

Changes

Files	Change Summary
`launchable/commands/helper.py`	Updated function signatures and internal logic for session and build management functions.
`launchable/commands/record/build.py`	Modified function signatures and command-line options; improved handling of Git repositories.
`launchable/commands/record/session.py`	Adjusted type annotations and error handling for session commands; streamlined API request payloads.
`launchable/commands/record/tests.py`	Enhanced command-line option handling; updated test logic for processing test reports.
`launchable/commands/stats/test_sessions.py`	Updated type annotations and simplified flavor processing logic.
`launchable/commands/subset.py`	Changed parameter types and improved error handling for conflicting options.
`launchable/utils/click.py`	Refactored parameter types and added alias functionality for command groups.
`tests/commands/record/test_build.py`	Enhanced tests for build recording functionality, particularly with Git submodules and lineage.
`tests/commands/record/test_session.py`	Updated tests for session recording; refined error handling for flavor arguments.
`tests/utils/test_click.py`	Introduced new tests for the `KEY_VALUE` type; validated command-line argument conversion.
`tests/utils/test_key_value_type.py`	Removed old tests related to the `normalize_key_value_types` function.

Poem

In the meadow where rabbits play,
New changes hop in, brightening the day.
With functions refined and options clear,
Our code now dances, bringing cheer!
So let’s celebrate, with a joyful thump,
For every update, we give a happy jump! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

launchable-app[bot] commented 1 month ago

:white_check_mark: All Tests passed!

:heavy_multiplication_x:no tests failed :heavy_check_mark:169 tests passed

launchable-app[bot] commented 1 month ago

:x: Tests Failed

:heavy_multiplication_x:3 tests failed :heavy_check_mark:164 tests passed

2/6 test sessions failed

**:x: Test session [#3317444](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3317444) failed** [![os:ubuntu-20.04](https://img.shields.io/badge/os-ubuntu--20.04-blue.svg)](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3317444) [![python:3.11](https://img.shields.io/badge/python-3.11-blue.svg)](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3317444) [details on CI](https://github.com/launchableinc/cli/actions/runs/11118192561) _{:bell: no issues :heavy_multiplication_x:3 tests failed :heavy_check_mark:164 tests passed} **:x: Test session [#3317443](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3317443) failed** [![os:ubuntu-20.04](https://img.shields.io/badge/os-ubuntu--20.04-blue.svg)](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3317443) [![python:3.10](https://img.shields.io/badge/python-3.10-blue.svg)](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3317443) [details on CI](https://github.com/launchableinc/cli/actions/runs/11118192561) _{:bell: no issues :heavy_multiplication_x:3 tests failed :heavy_check_mark:164 tests passed}