[LCHIB-35] removing a failed experiment

kohsuke commented 1 month ago

Summary by CodeRabbit

New Features
- Simplified Workspace class by removing the mode attribute, streamlining workspace management.
Bug Fixes
- Adjusted methods and tests to reflect the removal of the mode parameter, enhancing overall functionality and reducing complexity in JSON payloads.
- Improved test cases for the split-subset command, increasing robustness and clarity.

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes in this pull request involve modifications to the Workspace class within the launchable/commands/record/build.py file. The mode attribute has been removed from the class and its constructor, simplifying the class's structure. Consequently, instances of Workspace are now created without the mode parameter in the list_sources and synthesize_workspaces functions. Additionally, the payload construction in the send function has been updated to exclude the mode field, leading to a cleaner implementation focused on essential attributes. The related test cases have also been adjusted to reflect these changes.

Changes

File Path	Change Summary
launchable/commands/record/build.py	- Removed `mode` attribute from `Workspace` class and constructor. - Updated instantiation of `Workspace` in `list_sources` and `synthesize_workspaces` to exclude `mode`. - Adjusted `send` function to remove `mode` from commit data payload.
tests/commands/record/test_build.py	- Removed `"mode"` fields from JSON payloads in assertions across multiple test methods (`test_submodule`, `test_no_submodule`, `test_no_git_directory`, and `test_commit_option_and_build_option`).
tests/commands/test_split_subset.py	- Added print statements for debugging in `test_split_by_group_names` method. - Updated `test_split_by_group_names_output_exclusion_rules` to include `--output-exclusion-rules` flag and modified assertions to use `assertCountEqual`.

Poem

🐇 In the meadow, changes bloom,
The Workspace sheds its heavy gloom.
No more modes to weigh it down,
Just clean paths where joy is found.
Hopping forth, with data light,
A simpler way, oh what a sight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

launchable-app[bot] commented 1 month ago

:white_check_mark: All Tests passed!

:heavy_multiplication_x:no tests failed :heavy_check_mark:169 tests passed

launchable-app[bot] commented 1 month ago

:x: Tests Failed

:heavy_multiplication_x:4 tests failed :heavy_check_mark:162 tests passed(1 flake)

3/6 test sessions failed

**:x: Test session [#3326442](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3326442) failed** [![os:ubuntu-20.04](https://img.shields.io/badge/os-ubuntu--20.04-blue.svg)](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3326442) [![python:3.12](https://img.shields.io/badge/python-3.12-blue.svg)](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3326442) [details on CI](https://github.com/launchableinc/cli/actions/runs/11152845382) _{:bell: no issues :heavy_multiplication_x:4 tests failed :heavy_check_mark:163 tests passed} **:x: Test session [#3326441](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3326441) failed** [![os:ubuntu-20.04](https://img.shields.io/badge/os-ubuntu--20.04-blue.svg)](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3326441) [![python:3.10](https://img.shields.io/badge/python-3.10-blue.svg)](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3326441) [details on CI](https://github.com/launchableinc/cli/actions/runs/11152845382) _{:bell: no issues :heavy_multiplication_x:5 tests failed :heavy_check_mark:162 tests passed} **:x: Test session [#3326440](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3326440) failed** [![os:ubuntu-20.04](https://img.shields.io/badge/os-ubuntu--20.04-blue.svg)](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3326440) [![python:3.9](https://img.shields.io/badge/python-3.9-blue.svg)](https://app.launchableinc.com/organizations/launchableinc/workspaces/cli/data/test-sessions/3326440) [details on CI](https://github.com/launchableinc/cli/actions/runs/11152845382) _{:bell: no issues :heavy_multiplication_x:4 tests failed :heavy_check_mark:163 tests passed}