search

launchbadge / sqlx

🧰 The Rust SQL Toolkit. An async, pure Rust SQL crate featuring compile-time checked queries without a DSL. Supports PostgreSQL, MySQL, and SQLite.
Apache License 2.0
12.36k stars 1.18k forks source link

Invert boolean for `migrate` error message. (#3275) #3276

Open nk9 opened 3 weeks ago

nk9 commented 3 weeks ago

fixes #3275

nk9 commented 3 weeks ago

Question: instead of "see docs," can/should we link to the exact section that's relevant? In this case https://docs.rs/sqlx/latest/sqlx/attr.test.html#automatic-test-database-management-requires-migrate-feature

nk9 commented 3 weeks ago

I see that other places in the code use e.g. cfg!(not(feature = "chrono")). I'm not sure if there's a difference between these two styles, but I am happy to align this if desired.

abonander commented 4 days ago

Question: instead of "see docs," can/should we link to the exact section that's relevant? In this case https://docs.rs/sqlx/latest/sqlx/attr.test.html#automatic-test-database-management-requires-migrate-feature

The biggest issue is the doc header getting changed and it not getting updated here; at most I'd link to the #[sqlx::test] attribute itself. Either way, the user should probably read the whole page to understand what they're doing anyway.

I see that other places in the code use e.g. cfg!(not(feature = "chrono")). I'm not sure if there's a difference between these two styles, but I am happy to align this if desired.

I don't care that much, but that does seem more readable.

abonander commented 4 days ago

@nk9 if you rebase it should fix the CI failures.