search

launchboxio / cluster-api-provider-proxmox

CAPI Provider for Proxmox
MIT License
3 stars 1 forks source link

Cluster Deletion Protection #17

Open robwittman opened 9 months ago

robwittman commented 9 months ago

To prevent accidental deletion of a cluster, users should be able to add protection to the cluster.

When a cluster is created, if spec.deletionProtection: true, then we attach a no-op finalizer to the cluster. When a delete request occurs on the cluster, we simply return from reconcile.

To delete the cluster, a user must first update the cluster with spec.deletionProtection: false, which will then allow reconciliation to complete.

We also need to document that spec.deletionTimestamp needs to be removed to reverse the resource deletion

robwittman commented 9 months ago

Adding a finalizer to the ProxmoxCluster itself does not prevent deletion of other resources. This is something that may need to be supported at the CAPI provider level

Edit: Because of this, moving out of v1.0.0 milestone