search

launchcodedev / app-config

Easy Configuration Loader with Strict Validation
https://app-config.dev
Mozilla Public License 2.0
69 stars 11 forks source link

Supports 'env' option in $extends and $override directives #151

Closed joelgallant closed 3 years ago

joelgallant commented 3 years ago

Closes #129 #131

cypress[bot] commented 3 years ago


Test summary

17 • 0 • 0 • 0

Run details
Project App Config
Status Passed
Commit 155fc8f2af
Started May 4, 2021 1:37 AM
Ended May 4, 2021 1:39 AM
Duration 02:29 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

codecov-commenter commented 3 years ago

Codecov Report

Merging #151 (155fc8f) into master (816d6d4) will increase coverage by 0.14%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   80.43%   80.57%   +0.14%     
==========================================
  Files          42       42              
  Lines        2402     2420      +18     
  Branches      574      578       +4     
==========================================
+ Hits         1932     1950      +18     
  Misses        470      470
Impacted Files Coverage Δ
app-config-node/src/file-source.ts 79.41% <66.66%> (ø)
app-config-core/src/parsed-value.ts 82.56% <87.50%> (-0.31%) :arrow_down:
app-config-node/src/environment.ts 93.10% <88.88%> (-0.78%) :arrow_down:
app-config-core/src/config-source.ts 69.60% <100.00%> (+0.24%) :arrow_up:
app-config-exec/src/index.ts 97.43% <100.00%> (ø)
app-config-extension-utils/src/index.ts 92.45% <100.00%> (ø)
app-config-extensions/src/env-directive.ts 100.00% <100.00%> (ø)
app-config-extensions/src/env-var-directive.ts 100.00% <100.00%> (ø)
app-config-extensions/src/extends-directive.ts 98.24% <100.00%> (+3.90%) :arrow_up:
app-config-extensions/src/substitute-directive.ts 97.80% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 816d6d4...155fc8f. Read the comment docs.

joelgallant commented 3 years ago

I managed to do this without making breaking changes, which is nice