search

launchcodedev / app-config

Easy Configuration Loader with Strict Validation
https://app-config.dev
Mozilla Public License 2.0
69 stars 11 forks source link

Fix global environment override not being used by $extends #172

Closed johnb8 closed 3 years ago

johnb8 commented 3 years ago

Currently we're setting the environment to use when loading the $extends file to whatever is given in the $extends directive, even when it's undefined. This results in the wrong or no environment being used when loading the $extends file

codecov-commenter commented 3 years ago

Codecov Report

Merging #172 (486cea3) into master (882f6f5) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   80.09%   80.11%   +0.01%     
==========================================
  Files          42       42              
  Lines        2482     2484       +2     
  Branches      593      594       +1     
==========================================
+ Hits         1988     1990       +2     
  Misses        494      494
Impacted Files Coverage Δ
app-config-extensions/src/extends-directive.ts 98.41% <100.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 882f6f5...486cea3. Read the comment docs.