launchcodedev / app-config

Easy Configuration Loader with Strict Validation
https://app-config.dev
Mozilla Public License 2.0
69 stars 11 forks source link

Adds some unit tests for local key initialization #83

Closed joelgallant closed 3 years ago

joelgallant commented 3 years ago

In an effort to improve code coverage, just chipping away at non-tested functions. (the ones that aren't are usually like this, requiring more instrumentation)

cypress[bot] commented 3 years ago



Test summary

1 0 0 0


Run details

Project App Config
Status Passed
Commit ec85d3391e
Started Jan 2, 2021 3:07 AM
Ended Jan 2, 2021 3:07 AM
Duration 00:09 💡
OS Linux Ubuntu - 18.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

codecov-io commented 3 years ago

Codecov Report

Merging #83 (ec85d33) into master (5cfa0d1) will increase coverage by 2.42%. The diff coverage is 86.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   67.32%   69.75%   +2.42%     
==========================================
  Files          21       21              
  Lines        1420     1448      +28     
  Branches      286      290       +4     
==========================================
+ Hits          956     1010      +54     
+ Misses        269      245      -24     
+ Partials      195      193       -2     
Impacted Files Coverage Δ
app-config/src/encryption.ts 46.30% <62.50%> (+8.17%) :arrow_up:
app-config/src/logging.ts 58.06% <66.66%> (+0.37%) :arrow_up:
app-config/src/test-util.ts 100.00% <100.00%> (ø)
app-config/src/common.ts 67.92% <0.00%> (+13.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cfa0d1...ec85d33. Read the comment docs.