search

launchdarkly / android-client-sdk

LaunchDarkly Client-side SDK for Android
Other
45 stars 23 forks source link

Sloppy ProGuard/R8 rules (consumer-proguard-rules.pro) prevent release build optimizations. #106

Closed valeriyo closed 3 years ago

valeriyo commented 4 years ago

The following rule in consumer-proguard-rules.pro:

-keep class com.launchdarkly.android.** { *; }

defeats all the benefits of the code minification/optimizations that R8 provides.

Please provide more specific rules that allow R8 to do its job.

gwhelanLD commented 4 years ago

Thanks for the suggestion, I've filed it internally (ch90782) as an enhancement to implement when time is available.

Thanks, @gwhelanLD

gwhelanLD commented 3 years ago

Hey @valeriyo,

The release optimization situation should be substantially improved in the 3.0.0 release. Thanks for the suggestion!

Let us know if you run into any more issues, @gwhelanLD