Fix isInternetConnected return false when user connect wifi and vpn (below Android 10)

lguipeng commented 3 years ago

Requirements

[x] I have added test coverage for new or changed functionality
[x] I have followed the repository's pull request submission guidelines
[x] I have validated my changes against all supported platform versions

Related issues

N/A

Describe the solution you've provided

When user devices(below Android 10) connect wifi and vpn, the isInternetConnected method will return false and caused LD to not work. So I add nwc.hasTransport(NetworkCapabilities.TRANSPORT_VPN) to perfect this logical judgment.

Describe alternatives you've considered

N/A

Additional context

N/A

bwoskow-ld commented 3 years ago

Hi @lguipeng ,

Thanks for the bug report and contribution. We'll validate this fix internally and will get back to you.

Cheers, @bwoskow-ld

Filed internally as 119724.

lguipeng commented 3 years ago

Hi @bwoskow-ld , I want to know the current status of this PR, Thank you!

bwoskow-ld commented 3 years ago

Hi @lguipeng, reviewing this PR is near the top of our queue of things to do. We should have an update for you soon.

launchdarkly / android-client-sdk

Fix isInternetConnected return false when user connect wifi and vpn (below Android 10) #137