search

launchdarkly / android-client-sdk

LaunchDarkly Client-side SDK for Android
Other
45 stars 23 forks source link

Update timber version to the 5.0.1 to avoid Using 'Log' instead of 'Timber'. Lint errors. #141

Closed YvgenTroshchiy closed 2 years ago

YvgenTroshchiy commented 2 years ago

Found that when we added launchdarkly to our project we've started observe new errors: Using "'Log' instead of 'Timber'" Danger error. But we didn't have Timber in our project.

After run dependency check I've found that launchdarkly contains timber.

| | | | | | +--- com.launchdarkly:launchdarkly-android-client-sdk:2.14.2 | | | | | | | +--- com.google.code.gson:gson:2.8.2 -> 2.8.6 | | | | | | | +--- com.launchdarkly:okhttp-eventsource:1.8.0 | | | | | | | | +--- com.squareup.okhttp3:okhttp:3.8.1 -> 3.14.7 () | | | | | | | | +--- org.slf4j:slf4j-api:1.7.22 -> 1.7.25 | | | | | | | | --- com.google.code.findbugs:jsr305:3.0.2 | | | | | | | +--- com.squareup.okhttp3:okhttp:3.12.2 -> 3.14.7 () | | | | | | | +--- com.jakewharton.timber:timber:4.7.1

And there is issue in Timber that was already fixed JakeWharton/timber#380

After I've added latest timber version implementation 'com.jakewharton.timber:timber:5.0.1' This errors disappears.