search

launchdarkly / android-client-sdk

LaunchDarkly Client-side SDK for Android
Other
45 stars 23 forks source link

Application Name is overridden #155

Closed Exaper closed 2 years ago

Exaper commented 2 years ago

Describe the bug SDK overrides application name string

To reproduce Integrate the SDK. Notice launchdarkly-android-client-sdk

Expected behavior SDK should not contain application name.

SDK version 3.1.1

Additional context Just remove the "app_name" string. SDK should not contain it (refer to other mature SDKs out there). Alternatively, rename app_name resource to something else like ld_app_name or launch_darkly_app_name.

louis-launchdarkly commented 2 years ago

Hello @Exaper, thank you for the contribution. The change you made seems good - we will test the change and if there is nothing else, we will merge your change for the next release. So I will close this issue and continue update in the PR.