launchdarkly / android-client-sdk

LaunchDarkly Client-side SDK for Android
Other
45 stars 23 forks source link

Is it `doubleVariation` or `floatVariation`? #159

Closed byencho closed 2 years ago

byencho commented 2 years ago

The 3.0.0 CHANGELOG entry makes the following claims:

When using the SDK with versions 3.0.0+, it is clear, though, that doubleVariation exists and floatVariation does not. You can also search the current codebase to see many references to doubleVariation but the only references to floatVariation are in the CHANGELOG.

Is this simply a mistake in the documentation?

eli-darkly commented 2 years ago

It's a mistake in the changelog— the names were simply reversed. That is, floatVariation existed in older versions, but this was inconsistent with all other LaunchDarkly SDKs and the product itself, which use double-precision floating point rather than single-precision for all numbers. So it's been standardized on double.

byencho commented 2 years ago

@eli-darkly OK good to know, thanks! Do you think it would be possible to correct the CHANGELOG then so that anyone looking at it now can get a better sense of the current state of the code?

louis-launchdarkly commented 2 years ago

Hello @byencho, we have fixed the CHANGELOG just now. Thank you for reporting the issue to us!

byencho commented 2 years ago

Excellent, thanks!